[all-commits] [llvm/llvm-project] 75e93e: [lldb][TerminalTest] Fix assertion failure

[Kazuki Sakamoto via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 75e93ec720739291640005681f062b0e1e8e0f53
      https://github.com/llvm/llvm-project/commit/75e93ec720739291640005681f062b0e1e8e0f53
  Author: Kazuki Sakamoto <sakamoto at splhack.org>
  Date:   2023-06-15 (Thu, 15 Jun 2023)

  Changed paths:
    M lldb/unittests/Host/posix/TerminalTest.cpp

  Log Message:
  -----------
  [lldb][TerminalTest] Fix assertion failure

D152712 replaced `llvm::sys::RetryAfterSignal(-1, ::open)` with
`FileSystem::Instance().Open` for bionic in PseudoTerminal::OpenSecondary, and
FileSystem::Instance() is failing with assertion on arm Linux.

The assertion should be FileSystem re-initialization check, therefore the
hypothesis is that TerminalTest tests are initializing FileSystem instance
repeatedly.

Use SubsystemRAII<FileSystem> to ensure tearing down the FileSystem instance.

Differential Revision: https://reviews.llvm.org/D153091