[all-commits] [llvm/llvm-project] 0e0837: [clang][NFC] Add a notice to desugarForDiagnostic

[zyn0217 via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0e08374abb2c61a3ae5c24d5f60be3b548da9778
      https://github.com/llvm/llvm-project/commit/0e08374abb2c61a3ae5c24d5f60be3b548da9778
  Author: Younan Zhang <zyn7109 at gmail.com>
  Date:   2023-06-15 (Thu, 15 Jun 2023)

  Changed paths:
    M clang/include/clang/AST/ASTDiagnostic.h
    M clang/lib/AST/ASTDiagnostic.cpp

  Log Message:
  -----------
  [clang][NFC] Add a notice to desugarForDiagnostic

`desugarForDiagnostic` only sets ShouldAKA to true if desugaring
happens, otherwise ShouldAKA is left intact and might be uninitialized.

Victims (including me):

https://github.com/llvm/llvm-project/commit/25bf8cb3c0e3c41231289a6ff0a37b6d49b24011

https://github.com/llvm/llvm-project/commit/0e8384a0fe4f03d60cd92aba1cae074512481ca2

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D152880