[all-commits] [llvm/llvm-project] 048204: [lldb] Remove lldbassert from DebugNamesDWARFIndex...

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Wed Jun 14 17:15:35 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 048204d6102ab984c067c1a1c9889edb7f58d419
      https://github.com/llvm/llvm-project/commit/048204d6102ab984c067c1a1c9889edb7f58d419
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2023-06-14 (Wed, 14 Jun 2023)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp

  Log Message:
  -----------
  [lldb] Remove lldbassert from DebugNamesDWARFIndex::GetGlobalVariables

34a8e6eee666 changed SymbolFileDWARF::GetDwoNum to
SymbolFileDWARF::GetFileIndex but changed the meaning from just DWO to
DWO and OSO which changed the meaning of the assert. The assert was
therefore removed from ManualDWARFIndex::GetGlobalVariables and
ManualDWARFIndex::GetGlobalVariables but was still present in
DebugNamesDWARFIndex::GetGlobalVariables. If we want to reintroduce the
assert, we need something with the old semantics for all 3.




More information about the All-commits mailing list