[all-commits] [llvm/llvm-project] 92420f: [clang-tidy] Fix false positive in `readability-na...

AMS21 via All-commits all-commits at lists.llvm.org
Tue Jun 13 11:14:18 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 92420f4aefbef49c3eccaf678bc23713a59e5eab
      https://github.com/llvm/llvm-project/commit/92420f4aefbef49c3eccaf678bc23713a59e5eab
  Author: AMS21 <AMS21.github at gmail.com>
  Date:   2023-06-13 (Tue, 13 Jun 2023)

  Changed paths:
    M clang-tools-extra/clang-tidy/readability/NamedParameterCheck.cpp
    M clang-tools-extra/docs/ReleaseNotes.rst
    M clang-tools-extra/test/clang-tidy/checkers/readability/named-parameter.cpp

  Log Message:
  -----------
  [clang-tidy] Fix false positive in `readability-named-parameter` for defaulted out-of-line special member functions

This fixes llvm#63056

Reviewed By: PiotrZSL

Differential Revision: https://reviews.llvm.org/D152825


  Commit: 311091e2b007ebe0da9877953a9a56a51102e60d
      https://github.com/llvm/llvm-project/commit/311091e2b007ebe0da9877953a9a56a51102e60d
  Author: AMS21 <AMS21.github at gmail.com>
  Date:   2023-06-13 (Tue, 13 Jun 2023)

  Changed paths:
    M clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
    M clang-tools-extra/docs/ReleaseNotes.rst
    M clang-tools-extra/test/clang-tidy/checkers/modernize/use-default-member-init-assignment.cpp
    M clang-tools-extra/test/clang-tidy/checkers/modernize/use-default-member-init.cpp

  Log Message:
  -----------
  [clang-tidy] Fix crash in `modernize-use-default-member-init`

This was causes by `getValueOfValueInit` unconditionally calling
`getScalarTypeKind` on the member type, which would then trigger an
assertions since arrays are not scalar type.

This fixes llvm#63285

Reviewed By: PiotrZSL

Differential Revision: https://reviews.llvm.org/D152802


Compare: https://github.com/llvm/llvm-project/compare/f94c7ffe4640...311091e2b007


More information about the All-commits mailing list