[all-commits] [llvm/llvm-project] e40e42: [HIP] Fix HIP path detection

Yaxun (Sam) Liu via All-commits all-commits at lists.llvm.org
Tue Jun 13 08:12:41 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e40e427a649df21ce9f11f0b688124855789e2ee
      https://github.com/llvm/llvm-project/commit/e40e427a649df21ce9f11f0b688124855789e2ee
  Author: Yaxun (Sam) Liu <yaxun.liu at amd.com>
  Date:   2023-06-13 (Tue, 13 Jun 2023)

  Changed paths:
    M clang/lib/Driver/ToolChains/AMDGPU.cpp
    M clang/test/Driver/hip-version.hip
    M clang/test/Driver/rocm-detect.hip

  Log Message:
  -----------
  [HIP] Fix HIP path detection

Fix two issues:

--hip-path should not do rigorous checking, i.e. if .hipVersion exists it
will use it, otherwise it will not error out but assumes the default
HIP version. This is to be consistent with --rocm-path behavior.

when HIP_PATH is empty, it should be ignored. This is to be consistent
with ROCM_PATH behavior.

Reviewed by: Artem Belevich

Differential Revision: https://reviews.llvm.org/D152734

Fixes: SWDEV-404771




More information about the All-commits mailing list