[all-commits] [llvm/llvm-project] b18ca7: Revert "[Driver] Mark many target-specific driver-...

[Hans via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b18ca7296ef16700fadac98abe7fac8c8b44b4da
      https://github.com/llvm/llvm-project/commit/b18ca7296ef16700fadac98abe7fac8c8b44b4da
  Author: Hans Wennborg <hans at chromium.org>
  Date:   2023-06-12 (Mon, 12 Jun 2023)

  Changed paths:
    M clang/include/clang/Driver/Options.td
    M clang/test/Driver/munaligned-access-unused.c
    M clang/test/Driver/x86-malign-branch.c

  Log Message:
  -----------
  Revert "[Driver] Mark many target-specific driver-only options as TargetSpecific"

This broke building the TSan runtime on Mac, see comment on
https://github.com/llvm/llvm-project/commit/5548843d692a92a7840f14002debc3cebcb3cdc3

> so that they get an error on other targets. This change uses let statements to
> apply `Flags = [TargetSpecific]` to options (mostly -m*) without specifying `Flags`.
> Follow-up to D151590.
>
> For some options, e.g. -mdefault-build-attributes (D31813), -mbranch-likely
> (D38168), -mfpu=/-mabi= (6890b9b71e525020ab58d436336664beede71575), a warning
> seems desired in at least certain cases. This is not the best practice, but this
> change works around them by not applying `Flags = [TargetSpecific]`.
>
> (
> For Intel CPU errata -malign-branch= family options, we also drop the unneeded
> NotXarchOption flag. This flag reports an error if the option is used with
> -Xarch_*. This error reporting does not seem very useful.
> )

This reverts commit 5548843d692a92a7840f14002debc3cebcb3cdc3.