[all-commits] [llvm/llvm-project] bd4f97: [libc] Improve memcmp latency and codegen

[Guillaume Chatelet via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bd4f978754758d5ef29d1f10370f45362da3de37
      https://github.com/llvm/llvm-project/commit/bd4f978754758d5ef29d1f10370f45362da3de37
  Author: Guillaume Chatelet <gchatelet at google.com>
  Date:   2023-06-12 (Mon, 12 Jun 2023)

  Changed paths:
    M libc/src/__support/macros/properties/architectures.h
    M libc/src/string/CMakeLists.txt
    M libc/src/string/memory_utils/CMakeLists.txt
    M libc/src/string/memory_utils/aarch64/memcmp_implementations.h
    M libc/src/string/memory_utils/bcmp_implementations.h
    M libc/src/string/memory_utils/memcmp_implementations.h
    M libc/src/string/memory_utils/memmove_implementations.h
    M libc/src/string/memory_utils/memset_implementations.h
    M libc/src/string/memory_utils/op_aarch64.h
    M libc/src/string/memory_utils/op_generic.h
    A libc/src/string/memory_utils/op_riscv.h
    M libc/src/string/memory_utils/op_x86.h
    M libc/src/string/memory_utils/utils.h
    M libc/src/string/memory_utils/x86_64/memcmp_implementations.h
    M libc/test/src/string/memory_utils/op_tests.cpp
    M utils/bazel/llvm-project-overlay/libc/BUILD.bazel

  Log Message:
  -----------
  [libc] Improve memcmp latency and codegen

This is based on ideas from @nafi to:
 - use a branchless version of 'cmp' for 'uint32_t',
 - completely resolve the lexicographic comparison through vector
   operations when wide types are available. We also get rid of byte
   reloads and serializing '__builtin_ctzll'.

I did not include the suggestion to replace comparisons of 'uint16_t'
with two 'uint8_t' as it did not seem to help the codegen. This can
be revisited in sub-sequent patches.

The code been rewritten to reduce nested function calls, making the
job of the inliner easier and preventing harmful code duplication.

Reviewed By: nafi3000

Differential Revision: https://reviews.llvm.org/D148717