[all-commits] [llvm/llvm-project] ea868d: [InstCombine][NFC] Add tests pre-implementation of...

jmciver via All-commits all-commits at lists.llvm.org
Fri Jun 9 15:10:55 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ea868d5748cef57aa88f4c96445a1fdfbdb3832d
      https://github.com/llvm/llvm-project/commit/ea868d5748cef57aa88f4c96445a1fdfbdb3832d
  Author: John McIver <john.mciver.iii at gmail.com>
  Date:   2023-06-09 (Fri, 09 Jun 2023)

  Changed paths:
    A llvm/test/Transforms/InstCombine/icmp-power2-and-icmp-shifted-mask.ll

  Log Message:
  -----------
  [InstCombine][NFC] Add tests pre-implementation of issue #54856

Provide both positive and negative testing using scalar and vector values for
issue #54856.

Reviewed By: goldstein.w.n

Differential Revision: https://reviews.llvm.org/D143044


  Commit: 1001f9031f3ed0ca2ff146889bf82c10cea149d5
      https://github.com/llvm/llvm-project/commit/1001f9031f3ed0ca2ff146889bf82c10cea149d5
  Author: John McIver <john.mciver.iii at gmail.com>
  Date:   2023-06-09 (Fri, 09 Jun 2023)

  Changed paths:
    M llvm/include/llvm/IR/PatternMatch.h
    M llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
    M llvm/test/Transforms/InstCombine/icmp-power2-and-icmp-shifted-mask.ll

  Log Message:
  -----------
  [InstCombine] Optimize and of icmps with power-of-2 and contiguous masks

Add an instance combine optimization for expressions of the form:

(%arg u< C1) & ((%arg & C2) != C2) -> %arg u< C2

Where C1 is a power-of-2 and C2 is a contiguous mask starting 1 bit below
C1. This commit resolves GitHub missed-optimization issue #54856.

Validation of scalar tests:
  - https://alive2.llvm.org/ce/z/JfKjiU
  - https://alive2.llvm.org/ce/z/AruHY_
  - https://alive2.llvm.org/ce/z/JAiR6t
  - https://alive2.llvm.org/ce/z/S2X2e5
  - https://alive2.llvm.org/ce/z/4cycdE
  - https://alive2.llvm.org/ce/z/NcDiLP

Validation of vector tests:
  - https://alive2.llvm.org/ce/z/ABY6tE
  - https://alive2.llvm.org/ce/z/BTJi3s
  - https://alive2.llvm.org/ce/z/3BKWpu
  - https://alive2.llvm.org/ce/z/RrAbkj
  - https://alive2.llvm.org/ce/z/nM6fsN

Reviewed By: goldstein.w.n

Differential Revision: https://reviews.llvm.org/D125717


Compare: https://github.com/llvm/llvm-project/compare/6f6298e5b348...1001f9031f3e


More information about the All-commits mailing list