[all-commits] [llvm/llvm-project] fb19fa: [llvm-dlltool] Implement the --no-leading-undersco...

[Martin Storsjö via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fb19fa2f3dfdd60d42c12ef28467d6f8f5149d6a
      https://github.com/llvm/llvm-project/commit/fb19fa2f3dfdd60d42c12ef28467d6f8f5149d6a
  Author: Martin Storsjö <martin at martin.st>
  Date:   2023-06-09 (Fri, 09 Jun 2023)

  Changed paths:
    M llvm/include/llvm/Object/COFFModuleDefinition.h
    M llvm/lib/Object/COFFModuleDefinition.cpp
    M llvm/lib/ToolDrivers/llvm-dlltool/DlltoolDriver.cpp
    M llvm/lib/ToolDrivers/llvm-dlltool/Options.td
    A llvm/test/tools/llvm-dlltool/no-leading-underscore.def

  Log Message:
  -----------
  [llvm-dlltool] Implement the --no-leading-underscore option

This requires being able to opt out from adding the leading underscores
in COFFModuleDefinition. Normally it is added automatically for I386
type targets. We could either move the decision entirely to all
callers, letting the caller check the machine type and decide whether
underscores should be added, or keep the logic mostly as is, but allowing
opting out from the behaviour on I386.

I went with keeping the interface as is for now.

Differential Revision: https://reviews.llvm.org/D152363