[all-commits] [llvm/llvm-project] 9080f6: [COFF] Remove misleading and unclear comments. NFC.

[Martin Storsjö via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9080f619461f3d68c8126dcde7c6f95dbae75347
      https://github.com/llvm/llvm-project/commit/9080f619461f3d68c8126dcde7c6f95dbae75347
  Author: Martin Storsjö <martin at martin.st>
  Date:   2023-06-08 (Thu, 08 Jun 2023)

  Changed paths:
    M llvm/include/llvm/Object/COFFModuleDefinition.h

  Log Message:
  -----------
  [COFF] Remove misleading and unclear comments. NFC.

It is not planned that GNU binutils would change this aspect of
its behaviour wrt how symbol decoration is done.

Differential Revision: https://reviews.llvm.org/D152359


  Commit: 8deeaef0291f3d63900eb3c61dc46625fb24aafb
      https://github.com/llvm/llvm-project/commit/8deeaef0291f3d63900eb3c61dc46625fb24aafb
  Author: Martin Storsjö <martin at martin.st>
  Date:   2023-06-08 (Thu, 08 Jun 2023)

  Changed paths:
    M llvm/lib/ToolDrivers/llvm-dlltool/DlltoolDriver.cpp

  Log Message:
  -----------
  [llvm-dlltool] Clarify parameters, simplify ArgList usage. NFC.

Add comments about unclear bool arguments to functions, switch to
hasArg instead of getLastArg for cases where we don't need to check
the argument's value.

Differential Revision: https://reviews.llvm.org/D152360


  Commit: 6540157fe389b3dc46e9a1306370acd79d40c183
      https://github.com/llvm/llvm-project/commit/6540157fe389b3dc46e9a1306370acd79d40c183
  Author: Martin Storsjö <martin at martin.st>
  Date:   2023-06-08 (Thu, 08 Jun 2023)

  Changed paths:
    M llvm/lib/ToolDrivers/llvm-dlltool/Options.td
    A llvm/test/tools/llvm-dlltool/ignored-opts.def

  Log Message:
  -----------
  [llvm-dlltool] Ignore the --temp-prefix option

llvm-dlltool tolerates unknown options as long as they are plain
flags, but if given the parameter value as a separate argument,
e.g. "--temp-prefix foo", it fails to ignore it.

Differential Revision: https://reviews.llvm.org/D152361


  Commit: 1d96e24dda2e3a925d5c28c00049edb0c2d6c743
      https://github.com/llvm/llvm-project/commit/1d96e24dda2e3a925d5c28c00049edb0c2d6c743
  Author: Martin Storsjö <martin at martin.st>
  Date:   2023-06-08 (Thu, 08 Jun 2023)

  Changed paths:
    M llvm/lib/ToolDrivers/llvm-lib/LibDriver.cpp

  Log Message:
  -----------
  [llvm-lib] Pass the right value of MingwDef to parseCOFFModuleDefinition

In llvm-lib cases, the MinGW specific behaviours shouldn't be
enabled.

Not adding any tests to check the corner case behaviours, as this
simply was a mistake when this codepath was added in
395ec4458fb7fc700551f7017c0a395d68c55873 / D144765.

Differential Revision: https://reviews.llvm.org/D152362


Compare: https://github.com/llvm/llvm-project/compare/9daab7fb02d2...1d96e24dda2e