[all-commits] [llvm/llvm-project] 4638eb: [ThinLTO] Ignore callee edge to global variable

Teresa Johnson via All-commits all-commits at lists.llvm.org
Thu Jun 8 06:44:24 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4638eb26603c8d1cd3c46167734356e2585afdfe
      https://github.com/llvm/llvm-project/commit/4638eb26603c8d1cd3c46167734356e2585afdfe
  Author: Teresa Johnson <tejohnson at google.com>
  Date:   2023-06-08 (Thu, 08 Jun 2023)

  Changed paths:
    M llvm/lib/Transforms/IPO/FunctionImport.cpp
    M llvm/test/Transforms/FunctionImport/Inputs/funcimport_var2.ll
    M llvm/test/Transforms/FunctionImport/funcimport_var.ll

  Log Message:
  -----------
  [ThinLTO] Ignore callee edge to global variable

Since the symbols in the ThinLTO summary are indexed by GUID we can end
up in corner cases where a callee edge in the combined index goes to a
summary for a global variable. This could happen in the case of hash
collisions, and in the case of SamplePGO profiles could potentially happen
due to code changes (since we synthesize call edges to GUIDs that were
inlined callees in the profiled code).

Handle this by simply ignoring any non-FunctionSummary callees.

Differential Revision: https://reviews.llvm.org/D152406




More information about the All-commits mailing list