[all-commits] [llvm/llvm-project] 8f360c: [libc] Temporarily suppress -fsanitize=function fo...

PiJoules via All-commits all-commits at lists.llvm.org
Wed Jun 7 11:46:35 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8f360c3560d4d9f093482368475ded761a8cb9ab
      https://github.com/llvm/llvm-project/commit/8f360c3560d4d9f093482368475ded761a8cb9ab
  Author: Leonard Chan <leonardchan at google.com>
  Date:   2023-06-07 (Wed, 07 Jun 2023)

  Changed paths:
    M libc/src/stdlib/qsort.cpp

  Log Message:
  -----------
  [libc] Temporarily suppress -fsanitize=function for qsort comparator

Recent upstream changes to -fsanitize=function find more instances of
function type mismatches. One case is with the comparator passed to this
class. Libraries like boringssl will tend to pass comparators that take
pointers to varying types while this comparator expects to accept const
void pointers. Ideally those tools would pass a function that strictly
accepts const void*s to avoid UB, or we'd have something like qsort_r/s.

Differential Revision: https://reviews.llvm.org/D152322




More information about the All-commits mailing list