[all-commits] [llvm/llvm-project] 84c033: [LICM] [Coroutines] Don't hoist threadlocals withi...

[Chuanqi Xu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 84c033d9ba37ef51c0ca6e637ef954ed41d8c32d
      https://github.com/llvm/llvm-project/commit/84c033d9ba37ef51c0ca6e637ef954ed41d8c32d
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2023-06-07 (Wed, 07 Jun 2023)

  Changed paths:
    M llvm/lib/Transforms/Scalar/LICM.cpp
    M llvm/test/Transforms/LICM/sink-with-coroutine.ll

  Log Message:
  -----------
  [LICM] [Coroutines] Don't hoist threadlocals within presplit coroutines

Close https://github.com/llvm/llvm-project/issues/63022

This is the following of https://reviews.llvm.org/D135550, which is
discussed in
https://discourse.llvm.org/t/rfc-unify-memory-effect-attributes/65579.
In my imagination, we could fix the issue fundamentally after we
introduces new memory kind thread id. But I am not very sure if we can
fix the issue fundamentally in time.

Besides that, I think the correctness is the most important. So it
should not be bad to land this given it is innocent.

Reviewed By: nikic

Differential Revision: https://reviews.llvm.org/D151774