[all-commits] [llvm/llvm-project] 2b09f5: [RISCV] Remove overly restrictive assert from nega...

Craig Topper via All-commits all-commits at lists.llvm.org
Tue Jun 6 18:56:14 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2b09f53b32a5eea3ff1c33319fb541aa570e456b
      https://github.com/llvm/llvm-project/commit/2b09f53b32a5eea3ff1c33319fb541aa570e456b
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2023-06-06 (Tue, 06 Jun 2023)

  Changed paths:
    M llvm/lib/Target/RISCV/RISCVISelLowering.cpp
    M llvm/test/CodeGen/RISCV/rvv/vfma-vp.ll

  Log Message:
  -----------
  [RISCV] Remove overly restrictive assert from negateFMAOpcode.

It's possible that both multiplicands are being negated. This won't
change the opcode, but we can delete the two negates. Allow this
case to get through negateFMAOpcode.

I think D152260 will also fix this test case, but in the future
it may be possible for an fneg to appear after we've already converted
to RISCVISD opcodes in which case D152260 won't help.

Reviewed By: fakepaper56

Differential Revision: https://reviews.llvm.org/D152296




More information about the All-commits mailing list