[all-commits] [llvm/llvm-project] db1d72: [RISCV] Don't persist invalid feature state on .op...

Jessica Clarke via All-commits all-commits at lists.llvm.org
Tue Jun 6 12:15:39 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: db1d72b155c65df26980f6113cb5961c3c706a81
      https://github.com/llvm/llvm-project/commit/db1d72b155c65df26980f6113cb5961c3c706a81
  Author: Jessica Clarke <jrtc27 at jrtc27.com>
  Date:   2023-06-06 (Tue, 06 Jun 2023)

  Changed paths:
    M llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp
    M llvm/test/MC/RISCV/option-invalid.s

  Log Message:
  -----------
  [RISCV] Don't persist invalid feature state on .option arch error

Otherwise subsequent .option arch, +foo directives (but not -, since
those have their own separate validation) fail the parseFeatureBits
check, leading to cascading errors.

Reviewed By: luismarques, MaskRay

Differential Revision: https://reviews.llvm.org/D152273




More information about the All-commits mailing list