[all-commits] [llvm/llvm-project] 444bb1: [mlir][Toy] Remove unnecessary transpose from chap...

Andrey Portnoy via All-commits all-commits at lists.llvm.org
Tue Jun 6 11:24:18 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 444bb1f1bbbd7450fd30acc4ac1091fe916a740f
      https://github.com/llvm/llvm-project/commit/444bb1f1bbbd7450fd30acc4ac1091fe916a740f
  Author: Andrey Portnoy <aportnoy at fastmail.com>
  Date:   2023-06-06 (Tue, 06 Jun 2023)

  Changed paths:
    M mlir/docs/Tutorials/Toy/Ch-1.md
    M mlir/test/Examples/Toy/Ch1/ast.toy

  Log Message:
  -----------
  [mlir][Toy] Remove unnecessary transpose from chapter 1 example

The call to 'multiply_transpose' in the initialization of the variable 'f' was
intended to have a shape mismatch. However the variable 'a' has shape <2, 3> and
the variable 'c' has shape <3, 2>, so the arguments 'transpose(a)' and 'c' have
in fact compatible shapes (<3, 2> both), the opposite of what is wanted here.
This commit removes the transpose so that arguments 'a' and 'c' have
incompatible shapes <2, 3> and <3, 2>, respectively.

Reviewed By: mehdi_amini

Differential Revision: https://reviews.llvm.org/D151897




More information about the All-commits mailing list