[all-commits] [llvm/llvm-project] c336c9: [C++20] [Modules] [Serialization] Don't write comm...

[Chuanqi Xu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c336c983bcd9bf3559c76ed4eb6b25fbafbcd361
      https://github.com/llvm/llvm-project/commit/c336c983bcd9bf3559c76ed4eb6b25fbafbcd361
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2023-06-06 (Tue, 06 Jun 2023)

  Changed paths:
    M clang/lib/Serialization/ASTWriter.cpp
    M clang/unittests/Serialization/CMakeLists.txt
    A clang/unittests/Serialization/NoCommentsTest.cpp

  Log Message:
  -----------
  [C++20] [Modules] [Serialization] Don't write comments to BMI for C++20 Named Modules

This patch forbids to write comment to BMIs for C++20 Named Modules.
Originally I thought this was helpful for language services like clangd.
But I found clangd don't want the BMI to contain comments actually. So
it is meaningless for C++20 Named Modules to keep such comments in
their BMI.

It is simple to enable this when someday we found we want this actually.