[all-commits] [llvm/llvm-project] ab8d4f: [CMake] Quote variables where "TARGET" may be a value

Sam James via All-commits all-commits at lists.llvm.org
Mon Jun 5 18:09:13 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ab8d4f5a122fde5740f8c084c8165f51a26c93c7
      https://github.com/llvm/llvm-project/commit/ab8d4f5a122fde5740f8c084c8165f51a26c93c7
  Author: Sam James <sam at gentoo.org>
  Date:   2023-06-06 (Tue, 06 Jun 2023)

  Changed paths:
    M llvm/cmake/modules/LLVM-Config.cmake

  Log Message:
  -----------
  [CMake] Quote variables where "TARGET" may be a value

In CMake, "TARGET" is a special keyword. But it's also an LLVM component, which
means downstreams may request "target" or "TARGET" from CMake. Quote such input
so "TARGET" is interpreted as a string rather than a keyword.

This is a followup to 75a0502fe0053c72b57b61143a55600814d931fd (D150884).

Fixes Meson's test suite and an issue which manifested identically to #61436
but appears to have been a slightly different problem.

Bug: https://github.com/mesonbuild/meson/issues/11642
Bug: https://github.com/llvm/llvm-project/issues/61436

Reviewed By: tstellar

Differential Revision: https://reviews.llvm.org/D152121




More information about the All-commits mailing list