[all-commits] [llvm/llvm-project] 0bb6f8: [lldb][NFCI] Change return type of REPL::GetSource...

Alex via All-commits all-commits at lists.llvm.org
Mon Jun 5 12:52:57 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0bb6f832fbf8ae022063c07e2090f07832136bd4
      https://github.com/llvm/llvm-project/commit/0bb6f832fbf8ae022063c07e2090f07832136bd4
  Author: Alex Langford <alangford at apple.com>
  Date:   2023-06-05 (Mon, 05 Jun 2023)

  Changed paths:
    M lldb/include/lldb/Expression/REPL.h
    M lldb/source/Expression/REPL.cpp
    M lldb/source/Plugins/REPL/Clang/ClangREPL.cpp
    M lldb/source/Plugins/REPL/Clang/ClangREPL.h

  Log Message:
  -----------
  [lldb][NFCI] Change return type of REPL::GetSourceFileBasename

These don't really need to be in the ConstString StringPool. I've
changed the return type to StringRef because on llvm.org and downstream
in the swift fork, this returns a constant value. We could change it to
return a std::string or something else if it needs to be able to change
between calls.

Differential Revision: https://reviews.llvm.org/D151962




More information about the All-commits mailing list