[all-commits] [llvm/llvm-project] 45b25d: [mlir][Vector] Disable 'vector.extract' folding fo...

[Diego Caballero via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 45b25d24f04dba7e3089453774544459f152ef95
      https://github.com/llvm/llvm-project/commit/45b25d24f04dba7e3089453774544459f152ef95
  Author: Diego Caballero <diegocaballero at google.com>
  Date:   2023-06-01 (Thu, 01 Jun 2023)

  Changed paths:
    M mlir/lib/Dialect/Vector/IR/VectorOps.cpp
    M mlir/test/Dialect/Vector/canonicalize.mlir

  Log Message:
  -----------
  [mlir][Vector] Disable 'vector.extract' folding for unsupported 0-D vectors

The `vector.extract` folding patterns do not support 0-D vectors
(actually, 0-D vector support couldn't even be implemented as a folding
pattern as it would require replacing `vector.extract` with a
`vector.extractelement` op). This patch is bailing out folding when 0-D
vectors are found.

Reviewed By: nicolasvasilache, hanchung

Differential Revision: https://reviews.llvm.org/D151847


  Commit: 0935c0556bedc35d841103b58eff9a6e3464ffe6
      https://github.com/llvm/llvm-project/commit/0935c0556bedc35d841103b58eff9a6e3464ffe6
  Author: Diego Caballero <diegocaballero at google.com>
  Date:   2023-06-01 (Thu, 01 Jun 2023)

  Changed paths:
    M mlir/lib/Dialect/Vector/Transforms/LowerVectorShapeCast.cpp
    M mlir/test/Dialect/Vector/vector-shape-cast-lowering-transforms.mlir

  Log Message:
  -----------
  [mlir][Vector] Add support for 0-D 'vector.shape_cast' lowering

This PR adds support for shape casting from and to 0-D vectors.

Reviewed By: nicolasvasilache, hanchung, awarzynski

Differential Revision: https://reviews.llvm.org/D151851


  Commit: d3e1398bef44774e0f7965b8933d20f824460825
      https://github.com/llvm/llvm-project/commit/d3e1398bef44774e0f7965b8933d20f824460825
  Author: Diego Caballero <diegocaballero at google.com>
  Date:   2023-06-01 (Thu, 01 Jun 2023)

  Changed paths:
    M mlir/lib/Dialect/Vector/Transforms/VectorTransferOpTransforms.cpp
    M mlir/test/Dialect/Vector/scalar-vector-transfer-to-memref.mlir

  Log Message:
  -----------
  [mlir][Vector] Prevent vector-to-scalar xfer patterns from triggering on sub-vectors

Patterns that convert extract(transfer_read) into a scalar load where
incorrectly triggering for cases where a sub-vector instead of a scalar
was extracted.

Reviewed By: nicolasvasilache, hanchung, awarzynski

Differential Revision: https://reviews.llvm.org/D151862


  Commit: 834fcfed248dc1cd0fe68158dbd1e5f9a9e19e3d
      https://github.com/llvm/llvm-project/commit/834fcfed248dc1cd0fe68158dbd1e5f9a9e19e3d
  Author: Diego Caballero <diegocaballero at google.com>
  Date:   2023-06-01 (Thu, 01 Jun 2023)

  Changed paths:
    M mlir/lib/Dialect/Vector/Transforms/VectorTransferOpTransforms.cpp
    M mlir/test/Dialect/Vector/vector-transfer-drop-unit-dims-patterns.mlir

  Log Message:
  -----------
  Reland "[mlir][Vector] Extend xfer drop unit dim patterns"

This reverts commit 76d71f3792b2b1864992446f7b1028b026dccd11.


Compare: https://github.com/llvm/llvm-project/compare/10e422dd4502...834fcfed248d