[all-commits] [llvm/llvm-project] ab2743: [lldb][NFCI] Remove use of ConstString from UnixSi...

Alex via All-commits all-commits at lists.llvm.org
Thu Jun 1 10:04:54 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ab27431596c4f61f84ce41e27aad09a4dde3fc5a
  Author: Alex Langford <alangford at apple.com>
  Date:   2023-06-01 (Thu, 01 Jun 2023)

  Changed paths:
    M lldb/include/lldb/Target/UnixSignals.h
    M lldb/source/Target/UnixSignals.cpp

  Log Message:
  [lldb][NFCI] Remove use of ConstString from UnixSignals::SignalCode

On llvm.org and all downstream forks that I'm aware of, SignalCodes are
always created from C string literals. They are never compared to
anything so they take up space in the ConstString StringPool for no
tangible benefit.

I've changed the type here to `const llvm::StringLiteral` instead of
using a `StringRef` or a `const char *` to express intent -- These
strings come from constant data whose lifetime is directly tied to that
of the running process (and are thus safe to store).

Differential Revision: https://reviews.llvm.org/D151516

More information about the All-commits mailing list