[all-commits] [llvm/llvm-project] e6830b: [clang][modules] NFCI: Extract optionality out of ...

Jan Svoboda via All-commits all-commits at lists.llvm.org
Tue May 30 21:24:42 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e6830b6028ec5434ccf8dbebdd992918f67b1751
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2023-05-30 (Tue, 30 May 2023)

  Changed paths:
    M clang-tools-extra/modularize/CoverageChecker.cpp
    M clang-tools-extra/modularize/ModularizeUtilities.cpp
    M clang/include/clang/Basic/Module.h
    M clang/lib/Basic/Module.cpp
    M clang/lib/Frontend/FrontendAction.cpp
    M clang/lib/Lex/ModuleMap.cpp
    M clang/lib/Lex/PPLexerChange.cpp
    M clang/lib/Serialization/ASTReader.cpp
    M clang/lib/Serialization/ASTWriter.cpp

  Log Message:
  [clang][modules] NFCI: Extract optionality out of `Module::{Header,DirectoryName}`

Most users of `Module::Header` already assume its `Entry` is populated. Enforce this assumption in the type system and handle the only case where this is not the case by wrapping the whole struct in `std::optional`. Do the same for `Module::DirectoryName`.

Depends on D151584.

Reviewed By: benlangmuir

Differential Revision: https://reviews.llvm.org/D151586

More information about the All-commits mailing list