[all-commits] [llvm/llvm-project] e1596d: [Remarks] Retain all remarks by default, add optio...

[Florian Hahn via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e1596d7d9be1659730403b95efb94dad13c8495a
      https://github.com/llvm/llvm-project/commit/e1596d7d9be1659730403b95efb94dad13c8495a
  Author: Florian Hahn <flo at fhahn.com>
  Date:   2023-05-26 (Fri, 26 May 2023)

  Changed paths:
    M llvm/docs/CommandGuide/dsymutil.rst
    M llvm/include/llvm/Remarks/RemarkLinker.h
    M llvm/lib/Remarks/RemarkLinker.cpp
    M llvm/test/tools/dsymutil/cmdline.test
    M llvm/tools/dsymutil/DwarfLinkerForBinary.cpp
    M llvm/tools/dsymutil/LinkUtils.h
    M llvm/tools/dsymutil/Options.td
    M llvm/tools/dsymutil/dsymutil.cpp
    M llvm/unittests/Remarks/RemarksLinkingTest.cpp

  Log Message:
  -----------
  [Remarks] Retain all remarks by default, add option to drop without DL.

At the moment, dsymutil drops all remarks without debug location.

There are many cases where debug location may be missing for remarks,
mostly due LLVM not preserving debug locations. When using bitstream
remarks for statistical analysis, those missed remarks mean we get an
incomplete picture.

The patch flips the default to keeping all remarks and leaving it to
tools that display remarks to filter out remarks without debug locations
as needed.

The new --remarks-drop-without-debug flag can be used to drop remarks
without debug locations, i.e. restore the previous behavior.

Reviewed By: thegameg

Differential Revision: https://reviews.llvm.org/D151089