[all-commits] [llvm/llvm-project] 3b0106: Fix MLIR bytecode reader for unregistered dialects

[Mehdi Amini via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3b0106fe9da9a3adf9bd4402c7bc6cfbb47f1ab8
      https://github.com/llvm/llvm-project/commit/3b0106fe9da9a3adf9bd4402c7bc6cfbb47f1ab8
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2023-05-25 (Thu, 25 May 2023)

  Changed paths:
    M mlir/lib/Bytecode/Reader/BytecodeReader.cpp
    A mlir/test/Bytecode/unregistered_dialect.mlir

  Log Message:
  -----------
  Fix MLIR bytecode reader for unregistered dialects

At the moment we accept (in tests) unregistered dialects and in particular:

  "new_processor_id_and_range"()

where there is no `.` separator. We probably will remove support for this
from the parser, but for now we're adding compatibility support in the
reader.

Differential Revision: https://reviews.llvm.org/D151386


  Commit: e84589c9cce0915b223d1c6eda3320f498b6a598
      https://github.com/llvm/llvm-project/commit/e84589c9cce0915b223d1c6eda3320f498b6a598
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2023-05-25 (Thu, 25 May 2023)

  Changed paths:
    M mlir/include/mlir/IR/OwningOpRef.h
    M mlir/lib/Tools/mlir-lsp-server/MLIRServer.cpp

  Log Message:
  -----------
  Specialize OwningOpRef::operator-> to work with pointers like Operation*

This just simplifies user code.

Differential Revision: https://reviews.llvm.org/D151407


  Commit: cfd90939f70805f9824ac6b99bbe3ef4e50c7e8b
      https://github.com/llvm/llvm-project/commit/cfd90939f70805f9824ac6b99bbe3ef4e50c7e8b
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2023-05-25 (Thu, 25 May 2023)

  Changed paths:
    M mlir/lib/AsmParser/Parser.cpp
    M mlir/lib/Bytecode/Reader/BytecodeReader.cpp
    A mlir/unittests/Bytecode/BytecodeTest.cpp
    A mlir/unittests/Bytecode/CMakeLists.txt
    M mlir/unittests/CMakeLists.txt

  Log Message:
  -----------
  Fix MLIR bytecode loading of resources

The bytecode reader didn't handle properly the case where resource names
conflicted and were renamed, leading to orphan handles in the IR as well
as overwriting the exiting resources.

Differential Revision: https://reviews.llvm.org/D151408


Compare: https://github.com/llvm/llvm-project/compare/c0261eb02bb0...cfd90939f708