[all-commits] [llvm/llvm-project] dbbcfe: Revert "[CodeGen] Skip null physical register in A...

Sergei Barannikov via All-commits all-commits at lists.llvm.org
Wed May 24 19:51:49 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dbbcfef64f0c189238dc2f93ff0edb56aa2eb680
      https://github.com/llvm/llvm-project/commit/dbbcfef64f0c189238dc2f93ff0edb56aa2eb680
  Author: Sergei Barannikov <barannikov88 at gmail.com>
  Date:   2023-05-25 (Thu, 25 May 2023)

  Changed paths:
    M llvm/lib/CodeGen/AggressiveAntiDepBreaker.cpp
    M llvm/lib/CodeGen/CriticalAntiDepBreaker.cpp

  Log Message:
  -----------
  Revert "[CodeGen] Skip null physical register in AntiDepBreaker (NFCI)"

This reverts commit d41f6cff030369d99ad62bbdba732552c08d48a6.

The commit contained wrong phabricator link.


  Commit: 0f3efb8d7f3f0c96c82a98c12d2a26404116cc56
      https://github.com/llvm/llvm-project/commit/0f3efb8d7f3f0c96c82a98c12d2a26404116cc56
  Author: Sergei Barannikov <barannikov88 at gmail.com>
  Date:   2023-05-25 (Thu, 25 May 2023)

  Changed paths:
    M llvm/lib/CodeGen/AggressiveAntiDepBreaker.cpp
    M llvm/lib/CodeGen/CriticalAntiDepBreaker.cpp

  Log Message:
  -----------
  [CodeGen] Skip null physical register in AntiDepBreaker (NFCI)

D151036 adds an assertions that prohibits iterating over sub- and
super-registers of a null register. This is already the case when
iterating over register units of a null register, and worked by
accident for sub- and super-registers.
The only place where the assertion is currently triggering is in
CriticalAntiDepBreaker::ScanInstruction. Other places are changed
in case new assertions are added and should be harmless otherwise.


Compare: https://github.com/llvm/llvm-project/compare/ad571e0d84b3...0f3efb8d7f3f


More information about the All-commits mailing list