[all-commits] [llvm/llvm-project] 7f033d: [llvm-debuginfo-analyzer] Support both Reference a...

[Scott Linder via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7f033d0f756e72359c525ed3ab371e064cf55cff
      https://github.com/llvm/llvm-project/commit/7f033d0f756e72359c525ed3ab371e064cf55cff
  Author: Scott Linder <Scott.Linder at amd.com>
  Date:   2023-05-23 (Tue, 23 May 2023)

  Changed paths:
    M llvm/include/llvm/DebugInfo/LogicalView/Readers/LVELFReader.h
    M llvm/lib/DebugInfo/LogicalView/Readers/LVELFReader.cpp
    A llvm/test/tools/llvm-debuginfo-analyzer/DWARF/Inputs/dw-at-specification.o
    A llvm/test/tools/llvm-debuginfo-analyzer/DWARF/dw-at-specification.test

  Log Message:
  -----------
  [llvm-debuginfo-analyzer] Support both Reference and Type attrs in single DIE

Relax the assumption that at most one Reference-or-Type-like attribute is
present on a DWARF DIE.

Add support for at most one Type attribute (i.e. DW_AT_import xor
DW_AT_type) and separately at most one Reference attribute (i.e.
DW_AT_specification xor DW_AT_abstract_origin xor ...).

Update comment describing old assumption and tag it as a "FIXME" to
reflect the fact that this is perhaps still not general enough.

Add a test based on the case which led me to encounter the bug in the
wild.

Reviewed By: CarlosAlbertoEnciso

Differential Revision: https://reviews.llvm.org/D150713