[all-commits] [llvm/llvm-project] 75eb3b: [libc++] Remove tests from ranges.pass.cpp which v...

[philnik777 via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 75eb3bd1a43db7d72be0a12edce4b1f6a2bb1fa7
      https://github.com/llvm/llvm-project/commit/75eb3bd1a43db7d72be0a12edce4b1f6a2bb1fa7
  Author: Nikolas Klauser <nikolasklauser at berlin.de>
  Date:   2023-05-23 (Tue, 23 May 2023)

  Changed paths:
    M libcxx/test/std/algorithms/alg.nonmodifying/alg.find/ranges.find.pass.cpp

  Log Message:
  -----------
  [libc++] Remove tests from ranges.pass.cpp which violate semantic requirements

This also removes some tests which we have grouped together into robust_from_*.pass.cpp tests.

Specifically, checking that
- `ranges::dangling` is returned is done in `libcxx/test/std/algorithms/ranges_robust_against_dangling.pass.cpp`
- `std::invoke` is used is done in `libcxx/test/std/algorithms/ranges_robust_against_omitting_invoke.pass.cpp`.
- implicit conversion to bool works is done in `libcxx/test/std/algorithms/ranges_robust_against_nonbool_predicates.pass.cpp`

Checking the comparison order is invalid because the `operator==` isn't symmetric.
Checking what the exact type of `operator==` is, is invalid because comparing the same object has to yield the same results if the objects are not modified.

Reviewed By: ldionne, #libc

Spies: EricWF, libcxx-commits

Differential Revision: https://reviews.llvm.org/D150588