[all-commits] [llvm/llvm-project] 986cbd: [clang][AST] TextNodeDumper should not evaluate th...

Takuya Shimizu via All-commits all-commits at lists.llvm.org
Mon May 22 09:02:12 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 986cbd80d1dc838c61abff24b8d7ac28dcf4ac2a
      https://github.com/llvm/llvm-project/commit/986cbd80d1dc838c61abff24b8d7ac28dcf4ac2a
  Author: Takuya Shimizu <shimizu2486 at gmail.com>
  Date:   2023-05-23 (Tue, 23 May 2023)

  Changed paths:
    M clang/docs/ReleaseNotes.rst
    M clang/lib/AST/TextNodeDumper.cpp
    M clang/test/AST/ast-dump-decl.cpp

  Log Message:
  -----------
  [clang][AST] TextNodeDumper should not evaluate the initializer of constexpr variable declaration when it has a dependent type

`TextNodeDumper` enabed through `-ast-dump` flag should not evlauate the initializer when it visits a constexpr `VarDecl` node if it has a dependent type.

I found a crashing case fixed by this change and added it as a test case.
`template <typename T> constexpr T call_init(0);`
Link: https://godbolt.org/z/3bG9Pjj5E

This is a fix for the regression caused by D146358

Differential Revision: https://reviews.llvm.org/D151033




More information about the All-commits mailing list