[all-commits] [llvm/llvm-project] a5e039: GlobalISel: Move fconstant matching into tablegen

[Matt Arsenault via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a5e03972f7bbd1669051a6885a2ca43db13c713e
      https://github.com/llvm/llvm-project/commit/a5e03972f7bbd1669051a6885a2ca43db13c713e
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2023-05-19 (Fri, 19 May 2023)

  Changed paths:
    M llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h
    M llvm/include/llvm/Target/GlobalISel/Combine.td
    M llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp

  Log Message:
  -----------
  GlobalISel: Move fconstant matching into tablegen

I don't really understand what the point of wip_match_opcode is.
It doesn't seem to have any purpose other than to list opcodes
to have all the logic in pure C++. You can't seem to  use it to
select multiple opcodes in the same way you use match.

Something is wrong with it, since the match emitter prints
"errors" if an opcode is covered by wip_match_opcode and
then appears in another pattern. For exmaple with this patch,
you see this several times in the build:

  error: Leaf constant_fold_fabs is unreachable
  note: Leaf idempotent_prop will have already matched

The combines are actually produced and the tests for them
do pass, so this seems to just be a broken warning.


  Commit: 4e20a8234cc774717601db9d6b470ad8c849e154
      https://github.com/llvm/llvm-project/commit/4e20a8234cc774717601db9d6b470ad8c849e154
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2023-05-19 (Fri, 19 May 2023)

  Changed paths:
    M llvm/include/llvm/Analysis/AssumeBundleQueries.h

  Log Message:
  -----------
  Fix broken C++ mode comment


  Commit: 6f0344f76a8e1fe0f6bebd062b9d1254502bb38c
      https://github.com/llvm/llvm-project/commit/6f0344f76a8e1fe0f6bebd062b9d1254502bb38c
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2023-05-19 (Fri, 19 May 2023)

  Changed paths:
    M llvm/test/Transforms/InstSimplify/floating-point-compare.ll

  Log Message:
  -----------
  ValueTracking: Add baseline tests for some assume handling


Compare: https://github.com/llvm/llvm-project/compare/d4e935240f02...6f0344f76a8e