[all-commits] [llvm/llvm-project] 315119: Fix quadratic behavior from Operation::setAttr() ...

Mehdi Amini via All-commits all-commits at lists.llvm.org
Fri May 19 14:02:03 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 31511900c68df693b38decaa99dd9f8dba61ef65
      https://github.com/llvm/llvm-project/commit/31511900c68df693b38decaa99dd9f8dba61ef65
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2023-05-19 (Fri, 19 May 2023)

  Changed paths:
    M mlir/lib/IR/Operation.cpp

  Log Message:
  -----------
  Fix quadratic behavior from Operation::setAttr()  (NFC)

This API tries to ensure some backward compatibility for properties,
but doing so in multiple-layers was causing quadratic behavior.
Instead of `setAttrs()` repeatingly calling to `setAttr()` we inline
the logic and apply it locally in a single traversal.

Fixes #62800

Differential Revision: https://reviews.llvm.org/D150993




More information about the All-commits mailing list