[all-commits] [llvm/llvm-project] 41714c: [lldb] Guarantee the lifetimes of all strings retu...

[Alex via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 41714c959d65ff1dd842bc0a0d44f90b06440c39
      https://github.com/llvm/llvm-project/commit/41714c959d65ff1dd842bc0a0d44f90b06440c39
  Author: Alex Langford <alangford at apple.com>
  Date:   2023-05-18 (Thu, 18 May 2023)

  Changed paths:
    M lldb/docs/design/sbapi.rst
    M lldb/source/API/SBAttachInfo.cpp
    M lldb/source/API/SBBreakpoint.cpp
    M lldb/source/API/SBBreakpointLocation.cpp
    M lldb/source/API/SBBreakpointName.cpp
    M lldb/source/API/SBCommandInterpreter.cpp
    M lldb/source/API/SBData.cpp
    M lldb/source/API/SBEvent.cpp
    M lldb/source/API/SBExpressionOptions.cpp
    M lldb/source/API/SBFrame.cpp
    M lldb/source/API/SBFunction.cpp
    M lldb/source/API/SBInstruction.cpp
    M lldb/source/API/SBLaunchInfo.cpp
    M lldb/source/API/SBModule.cpp
    M lldb/source/API/SBPlatform.cpp
    M lldb/source/API/SBProcess.cpp
    M lldb/source/API/SBProcessInfo.cpp
    M lldb/source/API/SBQueue.cpp
    M lldb/source/API/SBStream.cpp
    M lldb/source/API/SBStringList.cpp
    M lldb/source/API/SBTarget.cpp
    M lldb/source/API/SBThread.cpp
    M lldb/source/API/SBTrace.cpp
    M lldb/source/API/SBTraceCursor.cpp
    M lldb/source/API/SBType.cpp
    M lldb/source/API/SBTypeCategory.cpp
    M lldb/source/API/SBTypeFilter.cpp
    M lldb/source/API/SBTypeNameSpecifier.cpp
    M lldb/source/API/SBTypeSummary.cpp
    M lldb/source/API/SBTypeSynthetic.cpp
    M lldb/source/API/SBUnixSignals.cpp
    M lldb/source/API/SBValue.cpp
    M lldb/source/API/SBWatchpoint.cpp

  Log Message:
  -----------
  [lldb] Guarantee the lifetimes of all strings returned from SBAPI

LLDB should guarantee that the strings returned by SBAPI methods
live forever. I went through every method that returns a string and made
sure that it was added to the ConstString StringPool before returning if
it wasn't obvious that it was already doing so.
I've also updated the docs to document this behavior.

Differential Revision: https://reviews.llvm.org/D150804