[all-commits] [llvm/llvm-project] 16eb14: [lldb][NFCI] Switch to using llvm::DWARFAbbreviati...

[Alex via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 16eb14806d1ee88d9f0c6222c0d0953a208f7911
      https://github.com/llvm/llvm-project/commit/16eb14806d1ee88d9f0c6222c0d0953a208f7911
  Author: Alex Langford <alangford at apple.com>
  Date:   2023-05-18 (Thu, 18 May 2023)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/DWARF/CMakeLists.txt
    R lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.cpp
    R lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.h
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAbbrev.cpp
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAbbrev.h
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFDefines.h
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h
    M lldb/unittests/SymbolFile/DWARF/SymbolFileDWARFTests.cpp

  Log Message:
  -----------
  [lldb][NFCI] Switch to using llvm::DWARFAbbreviationDeclaration

Both LLVM and LLDB implement DWARFAbbreviationDeclaration. As of
631ff46cbf51, llvm's implementation of
DWARFAbbreviationDeclaration::extract behaves the same as LLDB's
implementation, making it easier to merge the implementations.

The only major difference between LLDB's implementation and LLVM's
implementation is that LLVM's DWARFAbbreviationDeclaration is slightly
larger. Specifically, it has some metadata that keeps track of the size
of a declaration (if it has a fixed size) so that it can potentially
optimize extraction in some scenarios. I think this increase in size
should be acceptable and possibly useful on the LLDB side.

Differential Revision: https://reviews.llvm.org/D150716