[all-commits] [llvm/llvm-project] 0e6610: [clangd] Tweak "provides" hover card when symbols ...

Sam McCall via All-commits all-commits at lists.llvm.org
Wed May 17 11:25:58 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0e66105a9260d80d58215c0c627f35e950c35b99
      https://github.com/llvm/llvm-project/commit/0e66105a9260d80d58215c0c627f35e950c35b99
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2023-05-17 (Wed, 17 May 2023)

  Changed paths:
    M clang-tools-extra/clangd/Hover.cpp
    M clang-tools-extra/clangd/unittests/HoverTests.cpp

  Log Message:
  -----------
  [clangd] Tweak "provides" hover card when symbols have the same name

Previously for overloaded functions we'd show:
  Provides: foo, bar bar bar bar

The symbol name is duplicated
  ==> only show unique names, since we're not displaying the signature

Commas are missing
  ==> fix the logic which was checking for "last element" by value
      (though after the above fix this bug is dead anyway)

While here, remove a redundant bounds check before take_front().

Differential Revision: https://reviews.llvm.org/D150683




More information about the All-commits mailing list