[all-commits] [llvm/llvm-project] 74d49b: [libcxxabi] define _LIBCPP_VERBOSE_ABORT

Nick Desaulniers via All-commits all-commits at lists.llvm.org
Wed May 17 09:43:14 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 74d49b203c95a1fcb59fdc57b6ab3ce1d4b91491
      https://github.com/llvm/llvm-project/commit/74d49b203c95a1fcb59fdc57b6ab3ce1d4b91491
  Author: Nick Desaulniers <ndesaulniers at google.com>
  Date:   2023-05-17 (Wed, 17 May 2023)

  Changed paths:
    M libcxxabi/src/cxa_demangle.cpp
    M libcxxabi/src/demangle/DemangleConfig.h

  Log Message:
  -----------
  [libcxxabi] define _LIBCPP_VERBOSE_ABORT

libc++ may be built with or without assertions. This causes definitions
of various methods of std::string_view to contain assertions and calls
to __libcpp_verbose_abort which libcxxabi does not provide. libcxxabi
does provide abort_message with the same interface, so define
_LIBCPP_VERBOSE_ABORT to use that. Otherwise D148566 will trigger
linkage failures for the missing symbol __libcpp_verbose_abort.

Link: https://libcxx.llvm.org/UsingLibcxx.html#enabling-the-safe-libc-mode

Reviewed By: #libc_abi, philnik, ldionne

Differential Revision: https://reviews.llvm.org/D149092




More information about the All-commits mailing list