[all-commits] [llvm/llvm-project] 631ff4: [DebugInfo][NFCI] Refactor DWARFAbbreviationDeclar...

[Alex via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 631ff46cbf51dce943f5c136bb6b2b283a8053c0
      https://github.com/llvm/llvm-project/commit/631ff46cbf51dce943f5c136bb6b2b283a8053c0
  Author: Alex Langford <alangford at apple.com>
  Date:   2023-05-16 (Tue, 16 May 2023)

  Changed paths:
    M llvm/include/llvm/DebugInfo/DWARF/DWARFAbbreviationDeclaration.h
    M llvm/lib/DebugInfo/DWARF/DWARFAbbreviationDeclaration.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFDebugAbbrev.cpp

  Log Message:
  -----------
  [DebugInfo][NFCI] Refactor DWARFAbbreviationDeclaration::extract

The motivation behind this refactor is to be able to use
DWARFAbbreviationDeclaration from LLDB. LLDB has its own implementation
of DWARFAbbreviationDeclaration that is very similar to LLVM's but it
has different semantics around error handling.

This patch modifies llvm::DWARFAbbreviationDeclaration::extract to
return an `llvm::Expected<ExtractState>` to differentiate between "I am
done extracting" and "An error has occured", something which the current
return type (bool) does not accurately capture.

Differential Revision: https://reviews.llvm.org/D150607