[all-commits] [llvm/llvm-project] 4072c8: [OpenMP] Compile assembly files as ASM, not C

[Martin Storsjö via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4072c8aee4c89c4457f4f30d01dc9bb4dfa52559
      https://github.com/llvm/llvm-project/commit/4072c8aee4c89c4457f4f30d01dc9bb4dfa52559
  Author: Martin Storsjö <martin at martin.st>
  Date:   2023-05-16 (Tue, 16 May 2023)

  Changed paths:
    M openmp/CMakeLists.txt
    M openmp/runtime/src/CMakeLists.txt

  Log Message:
  -----------
  [OpenMP] Compile assembly files as ASM, not C

Since CMake 3.20, CMake explicitly passes "-x c" (or equivalent)
when compiling a file which has been set as having the language
C. This behaviour change only takes place if "cmake_minimum_required"
is set to 3.20 or newer, or if the policy CMP0119 is set to new.

Attempting to compile assembly files with "-x c" fails, however
this is workarounded in many cases, as OpenMP overrides this with
"-x assembler-with-cpp", however this is only added for non-Windows
targets.

Thus, after increasing cmake_minimum_required to 3.20, this breaks
compiling the GNU assembly for Windows targets; the GNU assembly is
used for ARM and AArch64 Windows targets when building with Clang.
This patch unbreaks that.

Differential Revision: https://reviews.llvm.org/D150532


  Commit: 391b51b18f37dd2a130de12167f8b4416eb3210e
      https://github.com/llvm/llvm-project/commit/391b51b18f37dd2a130de12167f8b4416eb3210e
  Author: Martin Storsjö <martin at martin.st>
  Date:   2023-05-16 (Tue, 16 May 2023)

  Changed paths:
    M libcxx/utils/libcxx/test/dsl.py

  Log Message:
  -----------
  [libcxx] [test] Improve error reporting around invoked commands

This was requested in the review of D145807, but I had missed to
apply it before landing the patch.

Differential Revision: https://reviews.llvm.org/D150444


Compare: https://github.com/llvm/llvm-project/compare/be556c838de0...391b51b18f37