[all-commits] [llvm/llvm-project] 10a507: [lldb] Define lldbassert based on NDEBUG instead o...

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 10a50762caa6ac17dd063b28863a2ec60576c6f7
      https://github.com/llvm/llvm-project/commit/10a50762caa6ac17dd063b28863a2ec60576c6f7
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2023-05-16 (Tue, 16 May 2023)

  Changed paths:
    M lldb/docs/resources/contributing.rst
    M lldb/include/lldb/Utility/LLDBAssert.h
    M lldb/source/Utility/LLDBAssert.cpp

  Log Message:
  -----------
  [lldb] Define lldbassert based on NDEBUG instead of LLDB_CONFIGURATION_DEBUG

Whether assertions are enabled or not is orthogonal to the build type
which could lead to surprising behavior for lldbassert. Previously, when
doing a debug build with assertions disabled, lldbassert would become a
NOOP, rather than printing an error like it does in a release build. By
definining lldbassert in terms of NDEBUG, it behaves like a regular
assert when assertions are enabled, and like a soft assert.

Differential revision: https://reviews.llvm.org/D150639