[all-commits] [llvm/llvm-project] 8f8479: [clangd] downgrade missing-includes diagnostic to ...

[Sam McCall via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8f8479789a08a7ec68008b20d3889ccf7fbcda1c
      https://github.com/llvm/llvm-project/commit/8f8479789a08a7ec68008b20d3889ccf7fbcda1c
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2023-05-16 (Tue, 16 May 2023)

  Changed paths:
    M clang-tools-extra/clangd/IncludeCleaner.cpp
    M clang-tools-extra/clangd/test/include-cleaner-batch-fix.test

  Log Message:
  -----------
  [clangd] downgrade missing-includes diagnostic to Information level

In practice, a Warning on every occurrence is very unpopular, even on a codebase
with clear rules about direct inclusion & moderately good compliance.

This change has various practical effects (in vscode for concreteness):
  - makes the diagnostic decoration less striking (blue vs yellow)
  - makes these diagnostics visually distinct from others when reading
  - causes these diagnostics to sort last in the "problems" view
  - allows these diagnostics to be easily filtered from the "problems" view

Differential Revision: https://reviews.llvm.org/D149912