[all-commits] [llvm/llvm-project] 8a5450: Fix regression after D150436

XinWang10 via All-commits all-commits at lists.llvm.org
Tue May 16 05:05:40 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8a5450d322c0748d3ee35d66d0d85046b5172538
      https://github.com/llvm/llvm-project/commit/8a5450d322c0748d3ee35d66d0d85046b5172538
  Author: Wang, Xin10 <xin10.wang at intel.com>
  Date:   2023-05-16 (Tue, 16 May 2023)

  Changed paths:
    M llvm/utils/TableGen/AsmMatcherEmitter.cpp

  Log Message:
  -----------
  Fix regression after D150436

llvm-clang-x86_64-expensive-checks-debian will fail after D150436 merged.
The fail occurred in X86, I changed the sort rule in AsmMatcher in Patch D150436, so x86 code will arrive line 633 first(will not affect other targets).
The logic here want to use the order record written in source file to make AsmMatcher to first use AVX instructions, it used field HasPositionOrder.
But the condition here just makes sure one of the compared record is subclass of Instruction and has field HasPositionOrder true, and didn't check another.

(Committing on behalf of @XinWang10 to unblock broken expensive-cjhecks builds)

Differential Revision: https://reviews.llvm.org/D150651




More information about the All-commits mailing list