[all-commits] [llvm/llvm-project] 3237f5: [asan][win][test] Disable interception_failure_tes...

Tue May 16 04:54:30 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3237f568403b80a6df47dd88dcfb03cb3a99b633
      https://github.com/llvm/llvm-project/commit/3237f568403b80a6df47dd88dcfb03cb3a99b633
  Author: Alvin Wong <alvin at alvinhc.com>
  Date:   2023-05-16 (Tue, 16 May 2023)

  Changed paths:
    M compiler-rt/test/asan/TestCases/interception_failure_test.cpp

  Log Message:
  -----------
  [asan][win][test] Disable interception_failure_test.cpp for static asan

This test checks that asan does not intercept user-provided libc
functions, but on Windows the static asan runtime does intercept static
copies of libc functions, so this test is invalid for said environment.
It used to fail from a different linker error, but this no longer
happens with newer WinSDK. Refer to comments on
https://reviews.llvm.org/D149549.

Differential Revision: https://reviews.llvm.org/D150349

  Commit: 5ad8bbee238f9655c55f048b6ae8c9b40b4c87e5
      https://github.com/llvm/llvm-project/commit/5ad8bbee238f9655c55f048b6ae8c9b40b4c87e5
  Author: Alvin Wong <alvin at alvinhc.com>
  Date:   2023-05-16 (Tue, 16 May 2023)

  Changed paths:
    M compiler-rt/test/asan/TestCases/Windows/delay_dbghelp.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_aligned_mallocs.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_allocators_sanity.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_intercept_memchr.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_intercept_memcpy_indirect.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_intercept_strlen.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_malloc_left_oob.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_malloc_uaf.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_noreturn.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_null_deref.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_operator_array_new_left_oob.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_operator_array_new_with_dtor_left_oob.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_poison_unpoison.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_stack_use_after_return.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_thread_stack_array_left_oob.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_unload.cpp
    M compiler-rt/test/asan/TestCases/Windows/heapalloc.cpp
    M compiler-rt/test/asan/TestCases/Windows/heapalloc_dll_double_free.cpp
    M compiler-rt/test/asan/TestCases/Windows/heapalloc_dll_unload_realloc_uaf.cpp
    M compiler-rt/test/asan/TestCases/Windows/heapalloc_doublefree.cpp
    M compiler-rt/test/asan/TestCases/Windows/heapalloc_flags_fallback.cpp
    M compiler-rt/test/asan/TestCases/Windows/heapalloc_huge.cpp
    M compiler-rt/test/asan/TestCases/Windows/heapalloc_rtl_transfer.cpp
    M compiler-rt/test/asan/TestCases/Windows/heapalloc_transfer.cpp
    M compiler-rt/test/asan/TestCases/Windows/heapalloc_uaf.cpp
    M compiler-rt/test/asan/TestCases/Windows/heapalloc_zero_size.cpp
    M compiler-rt/test/asan/TestCases/Windows/heaprealloc.cpp
    M compiler-rt/test/asan/TestCases/Windows/heaprealloc_alloc_zero.cpp
    M compiler-rt/test/asan/TestCases/Windows/heaprealloc_zero_size.cpp
    M compiler-rt/test/asan/TestCases/Windows/recalloc_sanity.cpp
    M compiler-rt/test/asan/TestCases/Windows/report_globals_reload_dll.cpp
    M compiler-rt/test/asan/TestCases/Windows/report_globals_vs_freelibrary.cpp
    M compiler-rt/test/asan/TestCases/Windows/rtlallocateheap.cpp
    M compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_dll_unload_double_free.cpp
    M compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_dll_unload_realloc.cpp
    M compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_flags_fallback.cpp
    M compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_zero.cpp
    M compiler-rt/test/asan/TestCases/Windows/sanitizer_purge.cpp
    M compiler-rt/test/asan/TestCases/Windows/stack_use_after_return.cpp
    M compiler-rt/test/asan/TestCases/Windows/symbols_path.cpp
    M compiler-rt/test/asan/TestCases/Windows/user-exception.cpp
    M compiler-rt/test/asan/lit.cfg.py

  Log Message:
  -----------
  [asan][test][win] Port more tests to not use clang-cl on MinGW (2)

Continuation of D147432 and D147444.

Differential Revision: https://reviews.llvm.org/D150267

  Commit: 6282315f8ae52fda7d2eaa1e2ecd6d3dbb614f51
      https://github.com/llvm/llvm-project/commit/6282315f8ae52fda7d2eaa1e2ecd6d3dbb614f51
  Author: Alvin Wong <alvin at alvinhc.com>
  Date:   2023-05-16 (Tue, 16 May 2023)

  Changed paths:
    M compiler-rt/test/asan/TestCases/Windows/dll_heap_allocation.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_report_globals_symbolization_at_startup.cpp
    M compiler-rt/test/asan/TestCases/Windows/null_deref_multiple_dlls.cpp
    M compiler-rt/test/asan/TestCases/Windows/shadow_conflict_32.cpp

  Log Message:
  -----------
  [asan][test][win] Port more tests to not use clang-cl on MinGW (3)

This ports tests which requires additional link flags.

Differential Revision: https://reviews.llvm.org/D150268

  Commit: fe4a5a08b96a10c5941840729af55c4dc874c1bf
      https://github.com/llvm/llvm-project/commit/fe4a5a08b96a10c5941840729af55c4dc874c1bf
  Author: Alvin Wong <alvin at alvinhc.com>
  Date:   2023-05-16 (Tue, 16 May 2023)

  Changed paths:
    M compiler-rt/test/asan/TestCases/Windows/dll_global_dead_strip.c
    M compiler-rt/test/asan/TestCases/Windows/dll_intercept_memcpy.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_intercept_memset.cpp
    M compiler-rt/test/asan/TestCases/Windows/global_dead_strip.c
    M compiler-rt/test/asan/lit.cfg.py

  Log Message:
  -----------
  [asan][test][win] Port more tests to not use clang-cl on MinGW (4)

This ports some tests that requires dead stripping or ICF.

Differential Revision: https://reviews.llvm.org/D150269

  Commit: 51015af773775160c22df9a8252d34270f2698a2
      https://github.com/llvm/llvm-project/commit/51015af773775160c22df9a8252d34270f2698a2
  Author: Alvin Wong <alvin at alvinhc.com>
  Date:   2023-05-16 (Tue, 16 May 2023)

  Changed paths:
    M compiler-rt/test/asan/TestCases/Windows/rtlallocateheap.cpp
    M compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_dll_unload_double_free.cpp
    M compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_dll_unload_realloc.cpp
    M compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_flags_fallback.cpp
    M compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_zero.cpp

  Log Message:
  -----------
  [asan][test][win] Remove `REQUIRES: asan-rtl-heap-interception`

This appears to be a leftover from when these tests were first added in
D62927. Because of this, these tests had never run with `check-asan` or
`check-asan-dynamic`.

I've tested locally that these tests do pass on both i686 MSVC and MinGW
targets. They are disabled for 64-bit though, and I believe no LLVM
buildbots are testing for 32-bit Windows targets.

Differential Revision: https://reviews.llvm.org/D150270

  Commit: 65abcf6c0ce1315fa0404f5cd0f6b093c038794e
      https://github.com/llvm/llvm-project/commit/65abcf6c0ce1315fa0404f5cd0f6b093c038794e
  Author: Alvin Wong <alvin at alvinhc.com>
  Date:   2023-05-16 (Tue, 16 May 2023)

  Changed paths:
    R compiler-rt/test/asan/TestCases/Windows/coverage-dll-stdio.cpp
    R compiler-rt/test/asan/TestCases/Windows/dll_and_lib.cpp
    R compiler-rt/test/asan/TestCases/Windows/dll_cerr.cpp
    R compiler-rt/test/asan/TestCases/Windows/dll_control_c.cpp
    R compiler-rt/test/asan/TestCases/Windows/dll_large_function.cpp
    R compiler-rt/test/asan/TestCases/Windows/dll_seh.cpp
    R compiler-rt/test/asan/TestCases/Windows/iostream_sbo.cpp
    A compiler-rt/test/asan/TestCases/Windows/msvc/coverage-dll-stdio.cpp
    A compiler-rt/test/asan/TestCases/Windows/msvc/dll_and_lib.cpp
    A compiler-rt/test/asan/TestCases/Windows/msvc/dll_cerr.cpp
    A compiler-rt/test/asan/TestCases/Windows/msvc/dll_control_c.cpp
    A compiler-rt/test/asan/TestCases/Windows/msvc/dll_large_function.cpp
    A compiler-rt/test/asan/TestCases/Windows/msvc/dll_seh.cpp
    A compiler-rt/test/asan/TestCases/Windows/msvc/iostream_sbo.cpp
    A compiler-rt/test/asan/TestCases/Windows/msvc/lit.local.cfg.py
    A compiler-rt/test/asan/TestCases/Windows/msvc/seh.cpp
    A compiler-rt/test/asan/TestCases/Windows/msvc/tls_init.cpp
    A compiler-rt/test/asan/TestCases/Windows/msvc/use_after_return_linkage.cpp
    R compiler-rt/test/asan/TestCases/Windows/seh.cpp
    R compiler-rt/test/asan/TestCases/Windows/tls_init.cpp
    R compiler-rt/test/asan/TestCases/Windows/use_after_return_linkage.cpp

  Log Message:
  -----------
  [asan][test][win] Move MSVC-specific tests into a subdir

This moves all but one remaining tests which use clang-cl and test
MSVC-specific behaviour into its own subdirectory. `dll_host.cpp` test
is excluded from the move because other tests also depend on its source
file, making it not MSVC-specific.

Differential Revision: https://reviews.llvm.org/D150271

Compare: https://github.com/llvm/llvm-project/compare/fe5786d41644...65abcf6c0ce1