[all-commits] [llvm/llvm-project] 09c5d6: Revert "[clang][deps] Only cache files with specif...

[Jan Svoboda via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 09c5d69592f7df4db62063e4dd231a7e154bdac6
      https://github.com/llvm/llvm-project/commit/09c5d69592f7df4db62063e4dd231a7e154bdac6
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2023-05-15 (Mon, 15 May 2023)

  Changed paths:
    M clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h
    M clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp
    M clang/unittests/Tooling/DependencyScannerTest.cpp

  Log Message:
  -----------
  Revert "[clang][deps] Only cache files with specific extension"

This reverts commit d1e00b6f136ec71a4c95a7eb4fd81ec0ab547962.

Internally, there were issues with caching stat failures for .framework directories. We need some time for investigation to pinpoint what exactly was going wrong.


  Commit: 94d22b09bbb212773a226726ee03a44edbbe98c7
      https://github.com/llvm/llvm-project/commit/94d22b09bbb212773a226726ee03a44edbbe98c7
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2023-05-15 (Mon, 15 May 2023)

  Changed paths:
    M clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp

  Log Message:
  -----------
  [clang][deps] Do not cache PCM files

On incremental scan, caching an out-of-date PCM on the VFS layer causes each TU and each module to recompile the PCM again. This is huge performance problem. Stop caching ".pcm" files.

Reviewed By: Bigcheese

Differential Revision: https://reviews.llvm.org/D150615


Compare: https://github.com/llvm/llvm-project/compare/692ae97ae71d...94d22b09bbb2