[all-commits] [llvm/llvm-project] bb9749: Revert "[cmake] Disable GCC lifetime DSE" (to fix ...

Xi Ruoyao via All-commits all-commits at lists.llvm.org
Sat May 13 19:46:41 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bb974991f4c4457a2104b648d9797a0ed438ecc9
      https://github.com/llvm/llvm-project/commit/bb974991f4c4457a2104b648d9797a0ed438ecc9
  Author: Sam James <sam at gentoo.org>
  Date:   2023-05-14 (Sun, 14 May 2023)

  Changed paths:
    M llvm/cmake/modules/HandleLLVMOptions.cmake

  Log Message:
  -----------
  Revert "[cmake] Disable GCC lifetime DSE" (to fix authorship)

This reverts commit 94f7c961c78d8fdbc05898cfbbf88094de45c1ad.

Differential Revision: https://reviews.llvm.org/D150505


  Commit: ce990b542617e5b52f69707b103a2424bec5e53b
      https://github.com/llvm/llvm-project/commit/ce990b542617e5b52f69707b103a2424bec5e53b
  Author: Xi Ruoyao <xry111 at xry111.site>
  Date:   2023-05-14 (Sun, 14 May 2023)

  Changed paths:
    M llvm/cmake/modules/HandleLLVMOptions.cmake

  Log Message:
  -----------
  [cmake] Disable GCC lifetime DSE

LLVM data structures like llvm::User and llvm::MDNode rely on
the value of object storage persisting beyond the lifetime of the
object (#24952).  This is not standard compliant and causes a runtime
crash if LLVM is built with GCC and LTO enabled (#57740).  Until
these issues are fixed, we need to disable dead store eliminations
eliminations based on object lifetime.

Bug: https://github.com/llvm/llvm-project/issues/24952
Bug: https://github.com/llvm/llvm-project/issues/57740
Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106943

(This was originally committed as 94f7c961c78d8fdbc05898cfbbf88094de45c1ad but
I reverted it in b974991f4c4457a2104b648d9797a0ed438ecc9 to fix authorship.)

Reviewed By: MaskRay, thesamesam, nikic

Differential Revision: https://reviews.llvm.org/D150505

Signed-off-by: Sam James <sam at gentoo.org>


Compare: https://github.com/llvm/llvm-project/compare/939f927dfc38...ce990b542617


More information about the All-commits mailing list