[all-commits] [llvm/llvm-project] d9377c: ASan: unbreak Windows build by limiting backtrace*...

Thurston Dang via All-commits all-commits at lists.llvm.org
Fri May 12 22:57:05 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d9377c1deda2fa1ba8ee7a0a59831d22ec57284f
      https://github.com/llvm/llvm-project/commit/d9377c1deda2fa1ba8ee7a0a59831d22ec57284f
  Author: Thurston Dang <thurston at google.com>
  Date:   2023-05-13 (Sat, 13 May 2023)

  Changed paths:
    M compiler-rt/test/asan/TestCases/backtrace_interceptor.cpp
    M compiler-rt/test/asan/TestCases/backtrace_symbols_interceptor.cpp

  Log Message:
  -----------
  ASan: unbreak Windows build by limiting backtrace* tests to glibc

My newly added backtrace test (https://reviews.llvm.org/D150491)
broke the Windows buildbot (https://lab.llvm.org/buildbot/#/builders/127/builds/48103)
because they do not have execinfo.h.
I expect the same will happen with the backtrace_symbols test (https://reviews.llvm.org/D150498) as well.

This patch does a quick fix by restricting the test scope to glibc-2.27.
(A tricker fix would take into account SANITIZER_INTERCEPT_BACKTRACE,
which is defined as (SI_FREEBSD || SI_NETBSD || SI_GLIBC || SI_SOLARIS))




More information about the All-commits mailing list