[all-commits] [llvm/llvm-project] 0152f0: Reapply "[RISCVGatherScatterLowering] Minor code c...

Philip Reames via All-commits all-commits at lists.llvm.org
Fri May 12 17:33:23 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0152f013f6256aaeebb6c98b123ab958d931018b
      https://github.com/llvm/llvm-project/commit/0152f013f6256aaeebb6c98b123ab958d931018b
  Author: Philip Reames <preames at rivosinc.com>
  Date:   2023-05-12 (Fri, 12 May 2023)

  Changed paths:
    M llvm/lib/Target/RISCV/RISCVGatherScatterLowering.cpp

  Log Message:
  -----------
  Reapply "[RISCVGatherScatterLowering] Minor code cleanup [NFC]"

This was reverted in 4e84149c0aea0e9f16c51cc92f50d90992b13d57 due to a problem report which has been confirmed to be misattributed.

Original commit message:

Use a switch to avoid repeat tests on the opcode, and factor out some common code out of another switch.  (Not all branches had both common bits, but the one which didn't left the values unchanged and their starting value is the respective operand - so storing it back is a nop.)


  Commit: 4cc2010f0368b71316acd5895f9a016e7f34c5fb
      https://github.com/llvm/llvm-project/commit/4cc2010f0368b71316acd5895f9a016e7f34c5fb
  Author: Philip Reames <preames at rivosinc.com>
  Date:   2023-05-12 (Fri, 12 May 2023)

  Changed paths:
    M llvm/lib/Target/RISCV/RISCVGatherScatterLowering.cpp
    M llvm/test/CodeGen/RISCV/rvv/fixed-vector-strided-load-store.ll
    M llvm/test/CodeGen/RISCV/rvv/strided-load-store.ll

  Log Message:
  -----------
  [RISCVGatherScatterLowering] Use InstSimplifyFolder

Main value of this is simplifying code, and making a few of the tests easier to read.

Differential Revision: https://reviews.llvm.org/D150474


Compare: https://github.com/llvm/llvm-project/compare/9c0a349788d3...4cc2010f0368


More information about the All-commits mailing list