[all-commits] [llvm/llvm-project] cf47e9: [Serialization] Don't try to complete the redeclar...

[Chuanqi Xu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cf47e9fe86aa65b74b0476a5ad4d036dd7463bfb
      https://github.com/llvm/llvm-project/commit/cf47e9fe86aa65b74b0476a5ad4d036dd7463bfb
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2023-05-12 (Fri, 12 May 2023)

  Changed paths:
    M clang/include/clang/Serialization/ASTReader.h
    M clang/lib/Serialization/ASTReader.cpp
    M clang/test/Modules/polluted-operator.cppm

  Log Message:
  -----------
  [Serialization] Don't try to complete the redeclaration chain in
ASTReader after we start writing

This is intended to mitigate
https://github.com/llvm/llvm-project/issues/61447.

Before the patch, it takes 5s to compile test.cppm in the above
reproducer. After the patch it takes 3s to compile it. Although this
patch didn't solve the problem completely, it should mitigate the
problem for sure. Noted that the behavior of the patch is consistent
with the comment of the originally empty function
ASTReader::finalizeForWriting. So the change should be consistent with
the original design.