[all-commits] [llvm/llvm-project] 3449e7: [mlir][bytecode] Fix dialect version parsing.

Jacques Pienaar via All-commits all-commits at lists.llvm.org
Thu May 11 05:19:25 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3449e7a832ba21f518e69c72985beea3b3c77a7e
      https://github.com/llvm/llvm-project/commit/3449e7a832ba21f518e69c72985beea3b3c77a7e
  Author: Jacques Pienaar <jpienaar at google.com>
  Date:   2023-05-11 (Thu, 11 May 2023)

  Changed paths:
    M mlir/lib/Bytecode/Reader/BytecodeReader.cpp
    M mlir/test/Bytecode/general.mlir
    M mlir/test/lib/Dialect/Test/TestDialect.cpp

  Log Message:
  -----------
  [mlir][bytecode] Fix dialect version parsing.

We were querying the wrong EncReader along some paths that resulted in
failures depending on if one encountered an Attribute from an unloaded
dialect before encountering an operation from that dialect.

Also fix error where we were able to emit "custom" form for an attribute
without custom form in TestDialect.

Differential Revision: https://reviews.llvm.org/D150260




More information about the All-commits mailing list