[all-commits] [llvm/llvm-project] 27b6a4: [lldb] Mark most SBAPI methods involving private t...

[Alex via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 27b6a4e63afe62f6258379a61177c67a670593c6
      https://github.com/llvm/llvm-project/commit/27b6a4e63afe62f6258379a61177c67a670593c6
  Author: Alex Langford <alangford at apple.com>
  Date:   2023-05-10 (Wed, 10 May 2023)

  Changed paths:
    M lldb/bindings/python/python-swigsafecast.swig
    M lldb/bindings/python/python-wrapper.swig
    M lldb/include/lldb/API/SBBreakpoint.h
    M lldb/include/lldb/API/SBBreakpointLocation.h
    M lldb/include/lldb/API/SBCommandInterpreter.h
    M lldb/include/lldb/API/SBCommandReturnObject.h
    M lldb/include/lldb/API/SBDebugger.h
    M lldb/include/lldb/API/SBError.h
    M lldb/include/lldb/API/SBEvent.h
    M lldb/include/lldb/API/SBExecutionContext.h
    M lldb/include/lldb/API/SBFrame.h
    M lldb/include/lldb/API/SBProcess.h
    M lldb/include/lldb/API/SBQueue.h
    M lldb/include/lldb/API/SBQueueItem.h
    M lldb/include/lldb/API/SBStructuredData.h
    M lldb/include/lldb/API/SBSymbolContext.h
    M lldb/include/lldb/API/SBTarget.h
    M lldb/include/lldb/API/SBThread.h
    M lldb/include/lldb/API/SBThreadPlan.h
    M lldb/include/lldb/API/SBTrace.h
    M lldb/include/lldb/API/SBTraceCursor.h
    M lldb/include/lldb/API/SBType.h
    M lldb/include/lldb/API/SBTypeSummary.h
    M lldb/include/lldb/API/SBValue.h
    M lldb/include/lldb/API/SBWatchpoint.h
    M lldb/source/API/SBCommandInterpreter.cpp
    M lldb/source/API/SBDebugger.cpp
    M lldb/source/Plugins/ScriptInterpreter/Python/SWIGPythonBridge.h
    M lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp
    M lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPlatformPythonInterface.cpp
    M lldb/source/Plugins/ScriptInterpreter/Python/ScriptedProcessPythonInterface.cpp
    M lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.cpp
    M lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h
    M lldb/source/Plugins/ScriptInterpreter/Python/ScriptedThreadPythonInterface.cpp
    M lldb/unittests/API/CMakeLists.txt
    M lldb/unittests/API/SBCommandInterpreterTest.cpp
    R lldb/unittests/API/SBStructuredDataTest.cpp
    M lldb/unittests/ScriptInterpreter/Python/PythonTestSuite.cpp

  Log Message:
  -----------
  [lldb] Mark most SBAPI methods involving private types as protected or private

Many SB classes have public constructors or methods involving types that
are private. Some are more obvious (e.g. containing lldb_private in the
name) than others (lldb::FooSP is usually std::shared_pointer<lldb_private::Foo>).

This commit explicitly does not address FileSP, so I'm leaving that one
alone for now.

Some of these were for other SB classes to use and should have been made
protected/private with a friend class entry added. Some of these were
public for some of the swig python helpers to use. I put all of those
functions into a class and made them static methods. The relevant SB
classes mark that class as a friend so they can access those
private/protected members.

I've also removed an outdated SBStructuredData test (can you guess which
constructor it was using?) and updated the other relevant tests.

Differential Revision: https://reviews.llvm.org/D150157