[all-commits] [llvm/llvm-project] 7591a7: [AMDGPU][MC] Clean up DPP bound_ctrl handling

Diana via All-commits all-commits at lists.llvm.org
Wed May 10 02:41:14 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7591a7b6ea5a36653c22fcec9aaf5c81ebab5bd1
      https://github.com/llvm/llvm-project/commit/7591a7b6ea5a36653c22fcec9aaf5c81ebab5bd1
  Author: Diana Picus <Diana-Magda.Picus at amd.com>
  Date:   2023-05-10 (Wed, 10 May 2023)

  Changed paths:
    M llvm/docs/AMDGPUModifierSyntax.rst
    M llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
    M llvm/lib/Target/AMDGPU/SIInstrInfo.td
    M llvm/test/MC/AMDGPU/gfx11_asm_vop1_dpp16.s
    M llvm/test/MC/AMDGPU/gfx11_asm_vop2_dpp16.s
    M llvm/test/MC/AMDGPU/gfx11_asm_vop3_dpp16.s
    M llvm/test/MC/AMDGPU/gfx11_asm_vop3_dpp16_from_vop1.s
    M llvm/test/MC/AMDGPU/gfx11_asm_vop3_dpp16_from_vop2.s
    M llvm/test/MC/AMDGPU/gfx11_asm_vop3_dpp16_from_vopc.s
    M llvm/test/MC/AMDGPU/gfx11_asm_vop3_dpp16_from_vopcx.s
    M llvm/test/MC/AMDGPU/gfx11_asm_vop3p_dpp16.s
    M llvm/test/MC/AMDGPU/gfx11_asm_vopc_dpp16.s
    M llvm/test/MC/AMDGPU/gfx11_asm_vopcx_dpp16.s

  Log Message:
  -----------
  [AMDGPU][MC] Clean up DPP bound_ctrl handling

At the moment, we set the BC bit in DPP for both bound_ctrl:0 and
bound_ctrl:1, for compatibility with sp3 (see PR35397). However, this
hack is only needed for GFX8. For newer GFXs, sp3 behaves as expected,
i.e. it sets the bit when bound_ctrl:1 and clears it when bound_ctrl:0.

This patch updates LLVM to do the same for GFX11 or newer. We preserve
the current behaviour for GFX9 and 10 so we don't break any existing
code.

Differential Revision: https://reviews.llvm.org/D149254




More information about the All-commits mailing list