[all-commits] [llvm/llvm-project] 58839f: [spirv][math] Fix sign propagation for math.powf c...

Lei Zhang via All-commits all-commits at lists.llvm.org
Tue May 9 21:51:10 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 58839f2e2913c2b7c0bb11a2292b8e666835cdb2
      https://github.com/llvm/llvm-project/commit/58839f2e2913c2b7c0bb11a2292b8e666835cdb2
  Author: Daniel Garvey <dan at nod-labs.com>
  Date:   2023-05-09 (Tue, 09 May 2023)

  Changed paths:
    M mlir/lib/Conversion/MathToSPIRV/MathToSPIRV.cpp
    M mlir/test/Conversion/MathToSPIRV/math-to-gl-spirv.mlir

  Log Message:
  -----------
  [spirv][math] Fix sign propagation for math.powf conversion

For `x^y`, the result's sign should consider whether `y` is
an integer and whether it's odd or even.

This still does not cover all corner cases regarding `x^y`
but it's an improvement over the current implementation.

Reviewed By: antiagainst, qedawkins

Differential Revision: https://reviews.llvm.org/D150234




More information about the All-commits mailing list