[all-commits] [llvm/llvm-project] 5d3a88: [IRGen] Change annotation metadata to support inse...

Zain Jaffal via All-commits all-commits at lists.llvm.org
Tue May 9 07:51:49 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5d3a8842295e8ff9c8c1c98e2acf5fff76b3a2f8
      https://github.com/llvm/llvm-project/commit/5d3a8842295e8ff9c8c1c98e2acf5fff76b3a2f8
  Author: Zain Jaffal <z_jaffal at apple.com>
  Date:   2023-05-09 (Tue, 09 May 2023)

  Changed paths:
    M llvm/docs/LangRef.rst
    M llvm/include/llvm/IR/Instruction.h
    M llvm/include/llvm/IR/Metadata.h
    M llvm/lib/CodeGen/BasicBlockSections.cpp
    M llvm/lib/CodeGen/MachineFunction.cpp
    M llvm/lib/IR/Metadata.cpp
    M llvm/lib/IR/Verifier.cpp
    M llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
    M llvm/lib/Transforms/Scalar/AnnotationRemarks.cpp
    M llvm/lib/Transforms/Utils/MemoryOpRemark.cpp
    M llvm/test/Verifier/annotation-metadata.ll

  Log Message:
  -----------
  [IRGen] Change annotation metadata to support inserting tuple of strings into annotation metadata array.

Annotation metadata supports adding singular annotation strings to annotation block. This patch adds the ability to insert a tuple of strings into the metadata array.

The idea here is that each tuple of strings represents a piece of information that can be all related. It makes it easier to parse through related metadata information given it will be contained in one tuple.
For example in remarks any pass that implements annotation remarks can have different type of remarks and pass additional information for each.

The original behaviour of annotation remarks is preserved here and we can mix tuple annotations and single annotations for the same instruction.

Reviewed By: paquette

Differential Revision: https://reviews.llvm.org/D148328




More information about the All-commits mailing list